Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#119 Modify XPath to retreive tables and references. #142

Merged
merged 3 commits into from
May 23, 2024

Conversation

nils-herrmann
Copy link
Contributor

Tables

The XPath was changed to parse the tables. Now any table-wrap node under body gets parsed.

References

It seems that some articles contain references with the attribute citation-type instead of publication-type. The new implementation parses also references with the attribute citation-type.

Copy link
Collaborator

@Michael-E-Rose Michael-E-Rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up the elif convolute, then undo some changes which don't belong to this PR.

pubmed_parser/pubmed_oa_parser.py Outdated Show resolved Hide resolved
tests/test_pubmed_oa_parser.py Outdated Show resolved Hide resolved
pubmed_parser/pubmed_oa_parser.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Michael-E-Rose Michael-E-Rose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea with the loop in the function

@Michael-E-Rose Michael-E-Rose merged commit f0bc9d2 into titipata:master May 23, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants